fix: duplicate page name error does not disappear on navigating to other pages#36320
Merged
KelvinOm merged 9 commits intoappsmithorg:releasefrom Sep 19, 2024
a6hishekpandey:fix/35949-duplicate-page-name-error-does-not-disappear
Merged
fix: duplicate page name error does not disappear on navigating to other pages#36320KelvinOm merged 9 commits intoappsmithorg:releasefrom a6hishekpandey:fix/35949-duplicate-page-name-error-does-not-disappear
KelvinOm merged 9 commits intoappsmithorg:releasefrom
a6hishekpandey:fix/35949-duplicate-page-name-error-does-not-disappear
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue: Duplicate page name error does not disappear on navigating to other pages.
This PR addresses issue #35949 by resetting the isPageNameValid state to undefined using useEffect hook when the Page settings loads.
Fixes #35949
Warning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags=""
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit